From: Jasper St. Pierre <jstpierre@mecheye.net>
Date: Wed, 20 Nov 2013 03:39:39 +0000 (-0500)
Subject: boxpointer: Don't hide when we're already hidden
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~3041
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=d77fc015801e60bb491eac5c5e65cbc347ebb0f4;p=gnome-shell.git

boxpointer: Don't hide when we're already hidden

You would think we would already do something like this, but apparently
lots of code was calling hide() without checking if the box pointer was
already visible, causing it to queue a full tween. The biggest win was
with ibusCandidatePopup.js, which called hide() on every DBus message.

This increases the performance for me to enter the overview by a tiny
bit. The remaining time is spent updating the frequent apps / all apps
display.

https://bugzilla.gnome.org/show_bug.cgi?id=712727
---

diff --git a/js/ui/boxpointer.js b/js/ui/boxpointer.js
index c8a15d3f9..e94033710 100644
--- a/js/ui/boxpointer.js
+++ b/js/ui/boxpointer.js
@@ -121,6 +121,9 @@ const BoxPointer = new Lang.Class({
     },
 
     hide: function(animate, onComplete) {
+        if (!this.actor.visible)
+            return;
+
         let xOffset = 0;
         let yOffset = 0;
         let themeNode = this.actor.get_theme_node();